fix(test): validate artifact run id default path#47
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks for the security-minded fix, @Lexiie! 🙏 #71 guards the artifact Genuinely appreciate the contribution — please keep them coming! 🚀 |
Summary
Fixes #45.
test artifact get <run-id>used the raw positionalrunIdas the final segment of the default output directory:That made the implicit destination path interpret path-like run IDs as filesystem structure. For example, a value like
../../outsidewould normalize outside the documented.testsprite/runs/artifact root when--outwas omitted.This PR treats
runIdas an opaque identifier for the implicit default path. If callers want a custom filesystem location, the existing explicit--out <dir>path remains the supported mechanism.Changes
resolveDefaultArtifactDir(runId, cwd)for the implicit artifact output directory../../\./.testsprite/runs/<run-id>/.Why
test artifact getwrites a multi-file failure bundle. The documented default path implies containment under.testsprite/runs/, while--outis already available for intentional custom paths. Failing closed on path-like positional IDs keeps the default artifact tree predictable and avoids surprising local writes.Verification
npx vitest run src/commands/test.artifact.spec.tsnpm run typecheck